Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pullapprove rules now that we allow selfapprovals #21494

Closed
wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar requested a review from vicb January 12, 2018 00:47
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 12, 2018
@ngbot
Copy link

ngbot bot commented Jan 12, 2018

I see that you just added the PR action: merge label. It won't do anything good though, because the following checks are still failing:

  • missing required label: "PR target:"
  • statuses failing/pending (code-review/pullapprove, continuous-integration/travis-ci/pr, ci/circleci: build, ci/circleci: lint)

If you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jan 12, 2018
@ngbot
Copy link

ngbot bot commented Jan 12, 2018

I see that you just added the PR action: merge label. It won't do anything good though, because the following checks are still failing:

  • missing required label: "PR target:"
  • statuses failing/pending (continuous-integration/travis-ci/pr, ci/circleci: build, ci/circleci: lint)

If you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know.

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Jan 12, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants